single-quote normalization#1155
Merged
ben merged 1 commit intoprogit:masterfrom Jan 9, 2019
ajax333221:master
Merged
Conversation
Member
|
Not sure that changing apostrophes to quotes is correct, though. |
Member
|
Looks like technically we should be using this syntax to be completely unambiguous: According to that document, the single-quote character should always produce a dumb vertical single-quote. However, it looks like the PDF version is getting smart quotes anyways – this section contains the text |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found the use of this single quote ’ instead of ' (which looks slightly different).
I found them on files with extension:
.sketch*.pdf*.png*.ico*.asc(15 files)* I didn't modify these since they are binary files which happen to contain them in their gibberishy binariness.
Then also noticed double single-quotation was being used (perhaps for some templating or idk), but I was careful not to mess with them (used a negative lookbehind regexp:
(?<!’)’)