Add hash-object to validate ruby hash function - #1081
Merged
Conversation
ben
reviewed
Jun 11, 2018
| => "bd9dbf5aae1a3862dd1526723246b20206e5fc37" | ||
| ---- | ||
|
|
||
| Let's validate the hash with `git hash-object`. It shows that they are identical. Note that `echo` will add a trailing newline character in string, which is not we want in this case. `echo -n` can prevent from adding a trailing newline character. |
Member
There was a problem hiding this comment.
Could you reformat this so that each sentence is on its own line? It makes future PRs much easier to review.
Also, let's make it a bit more succinct. Something like this maybe?
Let's compare that to the output of `git hash-object`.
Here we use `echo -n` to prevent adding a newline to the input.
What do you think?
| ---- | ||
| >> $ echo -n "what is up, doc?" | git hash-object --stdin | ||
| => bd9dbf5aae1a3862dd1526723246b20206e5fc37 | ||
| ---- |
Member
There was a problem hiding this comment.
Here you've got a shell sample marked up like it was typed into irb, which won't work. Could you remove the >> and => prefixes?
Contributor
Author
|
ping @ben |
Member
|
✨ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #1080