Don't use push(...arr) in GeometryBuilder for long vertex arrays#8789
Merged
Conversation
Continuous ReleaseCDN linkPublished PackagesCommit hash: c23d1c0 Previous deploymentsThis is an automated message. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #8788
Changes:
push(), which breaks if the array is bigger than the max number of function arguments in javascript,GeometryBuildernow uses a loop.Non-crashing version of the sketch in the issue: https://editor.p5js.org/davepagurek/sketches/n6BJZ0GWI
PR Checklist
npm run lintpasses