Make sure all p5.strands math operators are converted to strands nodes#8785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #8784
Changes
Previously, we were only ensuring something is a strands node before chaining strands methods on it like
.multif it's a variable name, an array, or a value literal. There are other cases where you could end up chaining methods though, one of which being if you reference a property of a js object.To be safe, now, instead of picking out specific types of code that need to be turned into a strands node, I've made it apply to everything. This has no effect if an operator is already a strands node other than the transpiled code looking a tad more complex, but means we'll always ensure we have a strands node before calling a method on it.
PR Checklist
npm run lintpasses