Repository navigation
Conversation
🦋 Changeset detectedLatest commit: 27ce8de The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #562 +/- ##
==========================================
- Coverage 92.19% 92.17% -0.02%
==========================================
Files 40 40
Lines 1973 1981 +8
Branches 582 582
==========================================
+ Hits 1819 1826 +7
- Misses 144 145 +1
Partials 10 10
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
I agree with the problem we're solving here but this would break for users who are say writing .d.ts files themselves not next to their .js sources and using the types field to point to it. I have some ideas on how to solve this problem (and some related ones) without causing more problems, I'll come back to this when I have a more concrete plan
|
Isn't the fix here to just do this when we have TS entrypoints? |
|
yeah, that should work (and it should also be per-entrypoint unlike the other fields) do you happen to know why both the |
|
Unfortunately, I don't know why both of those exist. |
closes #259