Skip to content

Add pass_filenames support - #265

Closed
mxr wants to merge 1 commit into
mainfrom
pass-filenames
Closed

mxr wants to merge 1 commit into
mainfrom
pass-filenames

Conversation

@mxr

@mxr mxr commented Apr 29, 2026

Copy link
Copy Markdown
Member

No description provided.

@mxr
mxr force-pushed the pass-filenames branch from 3ba0917 to 9e25d49 Compare May 1, 2026 11:18
@mxr
mxr force-pushed the pass-filenames branch from 9e25d49 to 62a63d2 Compare May 1, 2026 11:23
@mxr
mxr requested a review from asottile May 14, 2026 12:00
@mxr

mxr commented Jun 9, 2026

Copy link
Copy Markdown
Member Author

@asottile could you take a look please?

@asottile

Copy link
Copy Markdown
Member

as discussed offline -- I don't really want to encourage pass_filenames: false -- it's usually an indication that the tool is not a good fit for pre-commit (since one of the main points of pre-commit is to treat units of work as filename-based and skip when necessary, handle merge conflicts properly, partial staged contents, etc.). pass_filenames: false also often needs always_run: true which is also a smell.

@asottile asottile closed this Sep 26, 2026
@mxr

mxr commented Sep 26, 2026 •

Copy link
Copy Markdown
Member Author

That's fair. The only other argument I can think of is that the mirror should support all arguments as the hook definition "just because". Also I can accomplish what I want with a local hook (altho I have to manage versioning on my own)

@mxr
mxr deleted the pass-filenames branch September 26, 2026 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants