Always capitalize 'Mc'-prefixed small words in compound word groups#65
Merged
Conversation
ppannuto
requested changes
Jun 15, 2020
Owner
ppannuto
left a comment
ppannuto
left a comment
There was a problem hiding this comment.
I think this also makes sense to me. In this case, I think adding a comment (I gave a quick suggestion) indicating that this is somewhat of an arbitrary choice might help future readers understand why McBy is capitalized how it is.
Although there are no real surnames that start with ‘Mc’ and continues with a word matched by the SMALL_WORDS regex, it feels weird for a string like ‘mcto/mcby’ to be title-cased into ‘McTo/Mcby’, and not ‘McTo/McBy’, even though both ‘to’ and ‘by’ are small words—just because the small_first_last argument is set to False in the slash- or hyphen-induced recursion. Hence this fix.
ppannuto
approved these changes
Jun 15, 2020
Owner
|
Perfect, thanks again! |
ppannuto
added a commit
that referenced
this pull request
Jan 22, 2021
Major (interface) changes (#60) -- big thanks @iburago!!: - Read from an abbreviations file only when invoked from command line - Rename and refactor the create_wordlist_filter() function Minor changes: - #63: Do not capitalize small words occurring within hyphenated word groups (thanks @iburago!) - #65: Always capitalize 'Mc'-prefixed small words in compound word groups (thanks @iburago!) - #67: Don't capitalize Mr, Ms, Mrs (thanks @GurraB!) - #71: Add Manifest.in and include license file in src dist (thanks @synapticarbors!)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #64.