Repository navigation
пул реквест для первого проекта в яндекс практикуме - #1
Open
posleflamingo wants to merge 1 commit into
Open
posleflamingo wants to merge 1 commit into
posleflamingo wants to merge 1 commit into
Conversation
Komm mit Im Gleichschritt
Comment on lines
+2
to
+15
| class Car { | ||
| private String name; | ||
| private int speed; | ||
| public Car(String name, int speed) { | ||
| this.name = name; | ||
| this.speed = speed; | ||
| } | ||
| public String getName() { | ||
| return name; | ||
| } | ||
| public int getSpeed() { | ||
| return speed; | ||
| } | ||
| } |
There was a problem hiding this comment.
Данный класс предназначен только для хранения данных, которые все инициализируется в конструкторе, поэтому можно полям поставить модификатор final, убрать private и геттеры - получится то же самое, но будет прямой доступ к полям и меньше кода
| private int maxDistance = 0; | ||
|
|
||
| public void checkLeader(Car car) { | ||
| int distance = car.getSpeed() * 24; |
There was a problem hiding this comment.
Для повышения читабельности кода число 24 лучше вынести в константу с говорящим названием
| System.out.println("Введите скорость машины №" + i + ":"); | ||
| if (scanner.hasNextInt()) { | ||
| speed = scanner.nextInt(); | ||
| if (speed > 0 && speed <= 250) { |
There was a problem hiding this comment.
Минимальную и максимальную скорости лучше вынести в константы для повышения читабельности кода
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.