Increased asyncify data end to match stack size for built wasm modules#48
Merged
Merged
Conversation
Contributor
|
Great find @nerfZael! We should try and find a way to extract this from the wasm binary. Will add some thoughts to the issue you created 👏 |
dOrgJelli
approved these changes
Jun 26, 2023
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Toolchain is building wasm modules with the following stack size:
ENV ASYNCIFY_STACK_SIZE=24576But we don't take advantage of that in our AsyncifyWasmInstance.
Ideally, this should be dynamic, for that I created an issue here: #49
This fix should prevent any ASYNCIFY_STACK_SIZE errors in the mean time.