Skip to content

feat: add infinite loop error test for recursive resolver #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dOrgJelli merged 1 commit into from
Jun 23, 2023
Merged

feat: add infinite loop error test for recursive resolver #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/uri-resolvers/src/__tests__/recursive-resolver/histories/infinite-loop.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
[
"wrap://test/1 => InfiniteRedirectResolver => uri (wrap://test/2)",
"wrap://test/2 => InfiniteRedirectResolver => uri (wrap://test/3)",
"wrap://test/3 => InfiniteRedirectResolver => uri (wrap://test/1)"
]
56 changes: 56 additions & 0 deletions packages/uri-resolvers/src/__tests__/recursive-resolver/recursive-resolver.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,38 @@ class SimpleRedirectResolver implements IUriResolver<Error> {
}
}

class InfiniteRedirectResolver implements IUriResolver<Error> {
async tryResolveUri(
uri: Uri,
client: CoreClient,
resolutionContext: IUriResolutionContext
): Promise<Result<UriPackageOrWrapper, Error>> {
let result: Result<UriPackageOrWrapper, Error>;

switch (uri.uri) {
case "wrap://test/1":
result = UriResolutionResult.ok(Uri.from("test/2"));
break;
case "wrap://test/2":
result = UriResolutionResult.ok(Uri.from("test/3"));
break;
case "wrap://test/3":
result = UriResolutionResult.ok(Uri.from("test/1"));
break;
default:
result = UriResolutionResult.ok(uri);
}

resolutionContext.trackStep({
sourceUri: uri,
result,
description: "InfiniteRedirectResolver",
});

return result;
}
}

describe("RecursiveResolver", () => {
it("can recursively resolve a URI", async () => {
const uri = new Uri("test/1");
Expand Down Expand Up @@ -100,4 +132,28 @@ describe("RecursiveResolver", () => {

expect(result.value.uri.uri).toEqual("wrap://test/not-a-match");
});

it("should raise an error if infinite loop detected during URI Resolution", async () => {
const uri = new Uri("test/1");

const client = new PolywrapCoreClient({
resolver: RecursiveResolver.from(new InfiniteRedirectResolver()),
});

let resolutionContext = new UriResolutionContext();
let result = await client.tryResolveUri({ uri, resolutionContext });

await expectHistory(
resolutionContext.getHistory(),
"recursive-resolver",
"infinite-loop"
);

if (result.ok) {
fail(`Expected an error got value: ${result.value}`);
}

// @ts-ignore
expect(result.error!.message).toMatch("An infinite loop was detected while resolving the URI: wrap://test/1");
})
});