Skip to content

chore: migrate cache plugin from the integrations repo#3

Merged
Niraj-Kamdar merged 15 commits into
mainfrom
nk/cache-js
May 9, 2023
Merged

chore: migrate cache plugin from the integrations repo#3
Niraj-Kamdar merged 15 commits into
mainfrom
nk/cache-js

Conversation

@Niraj-Kamdar

@Niraj-Kamdar Niraj-Kamdar commented May 3, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Niraj-Kamdar
Niraj-Kamdar commented May 4, 2023
View reviewed changes
Comment thread implementations/in-memory/js/src/wrap/wrap.info.ts Outdated
krisbitney
krisbitney approved these changes May 8, 2023
View reviewed changes

@krisbitney krisbitney left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread implementations/in-memory/js/src/index.ts Outdated
@Niraj-Kamdar
Niraj-Kamdar merged commit f992670 into main May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dOrgJelli dOrgJelli Awaiting requested review from dOrgJelli dOrgJelli is a code owner
1 more reviewer
@krisbitney krisbitney krisbitney approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Cache plugin should use msgpack type for storing value Migrate implementation from integrations to this repo Cache plugin implementation

2 participants

@Niraj-Kamdar @krisbitney