Skip to content

Configurable base URI#596

Merged
jeremyrsmith merged 3 commits into
masterfrom
configurable-base-uri
Oct 31, 2019
Merged

Configurable base URI#596
jeremyrsmith merged 3 commits into
masterfrom
configurable-base-uri

Conversation

@jeremyrsmith

Copy link
Copy Markdown
Contributor
  • Make base URI configurable
  • Change absolute links to relative
  • Memoize index HTML if not in watch mode

Fixes #571, #579

- Make base URI configurable
- Change absolute links to relative
- Memoize index HTML if not in watch mode

@jonathanindig jonathanindig left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can you also add this new config to the template? (There might be a couple other new configs we forgot to add there as well)

@jeremyrsmith jeremyrsmith merged commit 0bcdd91 into master Oct 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Running Polynote using a proxy (binder)?

2 participants