This repository was archived by the owner on Oct 2, 2018. It is now read-only.
added version checking to virtualenv install not_if statement#75
Closed
willejs wants to merge 1 commit intopoise:masterfrom
Closed
added version checking to virtualenv install not_if statement#75willejs wants to merge 1 commit intopoise:masterfrom
willejs wants to merge 1 commit intopoise:masterfrom
Conversation
Member
|
This is no longer needed with 213c37e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When installing virtualenv pip errors, because pip's wheel archives are not supported in that version, and requires setuptools version 0.8 errors.
This cookbook packages setuptools 0.8, however, it only checks if setup tools is installed, if we are asserting to install it, lets make sure we check the version.
Therefore, I have amended the 'check' (by committing some python styling crimes), which checks the version is not less than 0.8, if it is it installs it, otherwise it doesent.