This repository was archived by the owner on Jul 3, 2021. It is now read-only.
Execute callback on booth join forbidden - Fixes #157#161
Merged
Conversation
Member
|
While this will fix these issues in particular, there are also other URLs that need to return the callback instead of throwing the error. When I created v5 to modernize plugAPI I did not test thoroughly the promise retries to see what issues may happen or edge cases. These are temporary band-aids to the issues happening as of currently, but if anyone has any way to fix it permanently that'd be great. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed patch for issue #157
This will send the error to the callback rather than throw an exception.