Repository navigation
Conversation
…cally The force-node-position loop tested node.x and node.y for truthiness, so a coordinate of 0 counted as missing and the node was positioned by the layout instead. Test for null and undefined only.
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing. Review the Copilot code review billing settings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #8150.
Apply a sankey node position of
0innode.xornode.y. Before this change, the layout placed such a node automatically.Changes
src/traces/sankey/render.js, the force-node-position loop testedtrace.node.x[p] && trace.node.y[p]. The value0is falsy, so the loop skipped the node. The loop now tests!= null, so only a missing value skips the node.test/jasmine/tests/sankey_test.jsthat places nodes atx = 0andy = 0.Testing
npm run test-jasmine -- sankey --nowatch: 92 of 92 specs pass.npm run lint,npm run typecheckandnpm run test-syntaxpass.ais at the top-left corner.sankey_x_y_with_arrowssetsy: [0, 0, 0], so its baseline changes: its nodes now sit at the top of the plot. No other sankey mock has a0coordinate. The new baseline will come from thebaselines-default-diffCI artifact.This change was developed with AI assistance.