Skip to content

Hide period label intersecting inside tick labels of the counter axis - #5582

Merged
archmoj merged 2 commits into
masterfrom
hide-period-label-intersecting-inside-label
Apr 10, 2021
Merged

archmoj merged 2 commits into
masterfrom
hide-period-label-intersecting-inside-label

Conversation

@archmoj

@archmoj archmoj commented Apr 7, 2021

Copy link
Copy Markdown
Contributor

Addressing #5502 (comment)

Before vs After

  • we also validated a mock in this PR.

@plotly/plotly_js

@alexcjohnson alexcjohnson left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and simple, love it - and a little mock cleanup to boot! 💃

@archmoj
archmoj merged commit 8f69805 into master Apr 10, 2021
@archmoj
archmoj deleted the hide-period-label-intersecting-inside-label branch April 10, 2021 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug something broken

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants