Skip to content

Bump mapbox-gl v1.12.0 - #5123

Closed
archmoj wants to merge 2 commits into
masterfrom
mapbox-gl-v1.12.0
Closed

Bump mapbox-gl v1.12.0#5123
archmoj wants to merge 2 commits into
masterfrom
mapbox-gl-v1.12.0

Conversation

@archmoj

@archmoj archmoj commented Sep 3, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Attempt bumping mapbox-gl to the latest version that could resolve #4926.

TODO:

  • figure out why two noCI tests are failing locally using npm run test-jasmine -- mapbox

@jonmmease this is not urgent at the moment. But it might be nice to be able to upgrade.

cc: @plotly/plotly_js

@archmoj archmoj added bug something broken feature something new status: reviewable labels Sep 3, 2020
@jonmmease

jonmmease commented Sep 3, 2020

Copy link
Copy Markdown
Contributor

Which tests are failing locally?

@archmoj

archmoj commented Sep 3, 2020

Copy link
Copy Markdown
Contributor Author

Which tests are failing locally?

plotly.js/test/jasmine/tests/mapbox_test.js

Lines 587 to 612 in 72c7f31

it('@gl should not update center while dragging', function(done) {
var map = gd._fullLayout.mapbox._subplot.map;
spyOn(map, 'setCenter').and.callThrough();
var p1 = [pointPos[0] + 50, pointPos[1] - 20];
_mouseEvent('mousemove', pointPos, noop).then(function() {
return Plotly.relayout(gd, {'mapbox.center': {lon: 13.5, lat: -19.5}});
}).then(function() {
// First relayout on mapbox.center results in setCenter call
expect(map.setCenter).toHaveBeenCalledWith([13.5, -19.5]);
expect(map.setCenter).toHaveBeenCalledTimes(1);
}).then(function() {
return _mouseEvent('mousedown', pointPos, noop);
}).then(function() {
return _mouseEvent('mousemove', p1, noop);
}).then(function() {
return Plotly.relayout(gd, {'mapbox.center': {lat: 0, lon: 0}});
}).then(function() {
return _mouseEvent('mouseup', p1, noop);
}).then(function() {
// Second relayout on mapbox.center does not result in a setCenter
// call since map drag is underway
expect(map.setCenter).toHaveBeenCalledTimes(1);
}).then(done);
}, LONG_TIMEOUT_INTERVAL);
See More

and

plotly.js/test/jasmine/tests/mapbox_test.js

Line 1289 in 72c7f31

it('@gl should respond drag / scroll / double-click interactions', function(done) {

fails.

@archmoj archmoj added type: maintenance and removed bug something broken feature something new labels Sep 3, 2020
@archmoj archmoj closed this Nov 10, 2021
@archmoj
archmoj deleted the mapbox-gl-v1.12.0 branch November 10, 2021 12:02
@archmoj archmoj mentioned this pull request Nov 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

investigate why unable to bump mapbox-gl from v1.10.1 to v1.11.0

2 participants

@archmoj @jonmmease