Pie-chart hover events - #150

@mdtusz you're right.

The concept of (sub)plots doesn't extend to pies. Pies are considered traces that have thier own domain and no corresponding axes.

What does evt contain here?

evt contains the data from the hover event - in this case, information on the slice that was hovered over. The plotly_hover event fires and gets passed data in the same format as the click events.

Right, but Fx.hover for pie traces should emit that same data as for non-pie traces minus the info about the axes of course.

The contents of [evt] mimic the same "format" as other traces hover events points value (as much as we can with a pie chart) but xvals/yvals and xaxes/yaxes are out of context here. The xvals/yvals are the mouse hover position relative to the axes scaling and values, so without any axes, these are meaningless.

Great. Thanks for the clarification. 🍻

@mdtusz On second thought, a check on _hasPie is too coerced.

Say we have a pie and bar trace on the same graph:

var gd = Tabs.fresh();

Plotly.plot(gd, 
    [
        {
            type: 'pie',
            labels: ['a', 'b', 'c'],
            values: [1, 2, 3],
            domain: {
                x: [0, 0.45]
            }
        },
        {
            type: 'bar',
            x: ['A', 'B', 'C'],
            y: [1, 2, 3],
        }

    ],
    {
        title: 'Pie vs bar',
        xaxis: { domain: [0.55, 1] },
        showlegend: false
    }
);

gd.on('plotly_hover', function(data) {
    var pt = data.points[0]
    console.log(pt);
});

then hovering over the bars will result in an un-formatted hover data.

So, we should use the subplot argument and make the if-clause: if(subplot === 'pie').

Good catch.

great. 🍻

Nice. Great test!