Gridlines which would intersect inside tick labels should not be drawn #5502

Activity

1. nicolaskruchten

   added

   bugsomething brokensomething broken

   sponsored

   on Feb 13, 2021
2. nicolaskruchten commented on Mar 16, 2021

   

   nicolaskruchten

   on Mar 16, 2021

   ContributorAuthor

   More actions

   Some additional context for this issue:

   • the core idea is that nothing should occlude or interfere with the inside tick labels, so that means gridlines and zerolines. Note that axis base lines don't interfere with the labels or ticks, so they can stay
   • the secondary idea is that nothing distracting should be drawn within the same extent even if it doesn't intersect, so no tick labels or ticks should appear on the X axis if they would appear below the inside tick labels on the Y axis. This is pretty straightforward in non-period-positioned cases: hide the gridlines and their ticks and labels
   • One tricky edge case would be with Y labels on the inside right with X labels in period-positioning mode: it would be quite possible to get a gridline that does not intersect the inside labels but its ticklabel would be drawn underneath them. In this case we should keep the gridline but drop the label.
3. nicolaskruchten commented on Mar 16, 2021

   

   nicolaskruchten

   on Mar 16, 2021

   ContributorAuthor

   More actions

   Addendum: for that final case, we should drop the label only if its centerline will intersect the y tick labels. That's more in keeping with the style guide in question.
4. archmoj commented on Mar 17, 2021

   

   archmoj

   on Mar 17, 2021

   Contributor

   More actions

   I noticed showing data without zerolines could be misleading in most cases.
5. nicolaskruchten commented on Mar 17, 2021

   

   nicolaskruchten

   on Mar 17, 2021

   ContributorAuthor

   More actions

   can you provide an example plz?
6. archmoj commented on Mar 17, 2021

   

   archmoj

   on Mar 17, 2021

   Contributor

   More actions

   can you provide an example plz?

   For example:

   
7. nicolaskruchten commented on Mar 17, 2021

   

   nicolaskruchten

   on Mar 17, 2021

   ContributorAuthor

   More actions

   fair enough. That seems unlikely-enough to be the developer's intent that I'm OK with this behaviour.
8. nicolaskruchten commented on Mar 17, 2021

   

   nicolaskruchten

   on Mar 17, 2021

   ContributorAuthor

   More actions

   I used the artifact from this branch in this pen https://codepen.io/nicolaskruchten/pen/BaLGYeW?editors=0010 (couldn't save because the URL is too long) and it seemed like the right-most ticklabel didn't disappear early enough as I panned. It seemed like it disappeared when its centerline hit the edge of the plot rather than the left edge of the inside ticklabel bounding boxes.
9. archmoj commented on Apr 7, 2021

   

   archmoj

   on Apr 7, 2021

   Contributor

   More actions

   This is fixed by #5550.
10. archmoj commented on Apr 7, 2021

    

    archmoj

    on Apr 7, 2021

    Contributor

    More actions

    This is fixed by #5550.

    Here is a codepen using master.
11. nicolaskruchten commented on Apr 7, 2021

    

    nicolaskruchten

    on Apr 7, 2021

    ContributorAuthor

    More actions

    Thanks! Do you have a pen that demonstrates this one?

    • One tricky edge case would be with Y labels on the inside right with X labels in period-positioning mode: it would be quite possible to get a gridline that does not intersect the inside labels but its ticklabel would be drawn underneath them. In this case we should keep the gridline but drop the label.
12. archmoj commented on Apr 7, 2021

    

    archmoj

    on Apr 7, 2021

    Contributor

    More actions

    Thanks! Do you have a pen that demonstrates this one?

    • One tricky edge case would be with Y labels on the inside right with X labels in period-positioning mode: it would be quite possible to get a gridline that does not intersect the inside labels but its ticklabel would be drawn underneath them. In this case we should keep the gridline but drop the label.

    Good call.
    Here is the codepen for the case of period.
    So it looks we need another PR to handle that period edge case.
13. nicolaskruchten

    closed this as completedon May 5, 2021