Skip to content

Mapbox subplots are broken in minified bundles #2787

Closed

Description

@etpinard

Starting in 1.39.0,

This one will be fun to debug 😑

Activity

  1. etpinard commented on Jul 6, 2018

    @etpinard
    ContributorAuthor
  2. etpinard commented on Jul 6, 2018

    @etpinard
    ContributorAuthor
  3. etpinard commented on Jul 6, 2018

    @etpinard
    ContributorAuthor

    Looks like bumping minify-stream from 1.1.0 to 1.2.0 in #2656 did this.

  4. etpinard commented on Jul 6, 2018

    @etpinard
    ContributorAuthor

    ⤴️ , bumping minify-stream isn't the whole story. [email protected] breaks for [email protected]+ (but worked fine with 0.44.x which we were using before 1.39.0) 😡

  5. etpinard commented on Jul 9, 2018

    @etpinard
    ContributorAuthor

    #2789 fixes this by disabling the compress step during minification. This fix is part of 1.39.1

    This solution is far from perfect, so I'll leave this issue open until/if we figure a better solution.

  6. etpinard commented on Jul 9, 2018

    @etpinard
    ContributorAuthor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugsomething broken

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions