Skip to content
This repository was archived by the owner on Aug 29, 2025. It is now read-only.

Allow both jpg and jpeg as possible file formats#54

Merged
etpinard merged 2 commits into
plotly:masterfrom
firefueled:imgopts-allow-jpg
Aug 29, 2017
Merged

Allow both jpg and jpeg as possible file formats#54
etpinard merged 2 commits into
plotly:masterfrom
firefueled:imgopts-allow-jpg

Conversation

@firefueled
Copy link
Copy Markdown
Contributor

I initially intended to simply correct the README, pointing out that the correct option is 'jpeg' and not 'jpg', but allowing both seems friendlier
I understand if y'all don't want ambiguity

I initially intended to simply correct the README, pointing out that the correct option is 'jpeg' and not 'jpg', but allowing both seems friendlier
@firefueled
Copy link
Copy Markdown
Contributor Author

Ohh it Fixes #53

@etpinard
Copy link
Copy Markdown
Contributor

Thanks for the catch!

I would prefer only accepting jpeg an erroring on jpg.

@firefueled
Copy link
Copy Markdown
Contributor Author

Yeah, that's what I expected. No problems. I'll send an update later today.

@firefueled
Copy link
Copy Markdown
Contributor Author

There ya go :)

@etpinard
Copy link
Copy Markdown
Contributor

Thanks!

@etpinard etpinard merged commit 874e89b into plotly:master Aug 29, 2017
@firefueled firefueled deleted the imgopts-allow-jpg branch August 29, 2017 02:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants