This repository was archived by the owner on Aug 29, 2025. It is now read-only.
Make plotly.saveImage return a callback when it has finished successfully.#10
Closed
oppenlander wants to merge 4 commits into
Closed
Make plotly.saveImage return a callback when it has finished successfully.#10oppenlander wants to merge 4 commits into
oppenlander wants to merge 4 commits into
Conversation
Contributor
|
Going to be making saveImage return a stream. Thanks for this, most of it got merged into another PR, and I'll work on cleaning the rest. Cheers! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously saveImage only called the callback when it failed.
It also did not check if the callback existed before trying to use it, even though it is an optional parameter.