Skip to content

BufferedWriter migration codemod text has incorrect claims #304

Closed

Description

@nahsra

There are benefits to the I/O performance and to the modernization of the change, but the codemod summary and documentation goes overboard in claims about how it helps. IIRC, there was a phased approach to this codemod -- first, modernize, second, wrap with try-catch/try-with-resources, and the documentation overstates the phase of where the codemod is. These need to match exactly.

The scope of this ticket is to reset the claims to match the codemod, or to improve the codemod to wrap with try-related protections. We should be able to compose this feature into the codemod from this codemod.

Credit: Joe Beeton, Contrast

Activity

  1. assigned and unassigned on Mar 11, 2024
  2. added a commit that references this issue on Apr 12, 2024
    7620608
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions