Skip to content

Virtualbox 5.2#68

Closed
Kunzol wants to merge 20 commits into
phpvirtualbox:developfrom
WaaromZoMoeilijk:virtualbox-5.2
Closed

Virtualbox 5.2#68
Kunzol wants to merge 20 commits into
phpvirtualbox:developfrom
WaaromZoMoeilijk:virtualbox-5.2

Conversation

@Kunzol
Copy link
Copy Markdown

@Kunzol Kunzol commented Oct 27, 2017

Update of WSDL files from virtualbox-5.2 source

@h6w
Copy link
Copy Markdown
Contributor

h6w commented Nov 10, 2017

How is this different from PR #66 ?

@Kunzol
Copy link
Copy Markdown
Author

Kunzol commented Nov 10, 2017

I guess the only difference is that in this PR the wsdl-files are explicitly generated from the source-tree of Virtualbox-5.2 and added as files. Which makes it easy to use.

@h6w
Copy link
Copy Markdown
Contributor

h6w commented Nov 12, 2017

The PR doesn't show there being a difference between wsdl files at all. There are only 3 files and 11 lines changed from the current files in the develop branch. That's why I was asking. I see 3 changes:

  1. A change in the text in README.md
  2. A change in the theme
  3. A change in PHPVBOX_VER.

Could it be that you pulled from master rather than from develop?

@Kunzol
Copy link
Copy Markdown
Author

Kunzol commented Nov 14, 2017

Actually I wanted to make the PR for ezraholm50/phpvirtualbox, because this looked like it was dead.
I don't know, why this PR is shown in the original, not in the fork. It seems that this PR contains all patches from that fork. If I knew, how to "undo" this, I would do it, and try it again.
Git seems to complex for me. I should go back to SVN.

@h6w
Copy link
Copy Markdown
Contributor

h6w commented Nov 15, 2017

You need to be on the branch linked to ezraholm50 if you want to push a PR to there. git set remote-url or some such IIRC.

I'll close this for you.

Cheers,
Tudor.

@h6w h6w closed this Nov 15, 2017
@Neustradamus
Copy link
Copy Markdown

Can you confirm if the latest 5.2.x (EOL): https://www.virtualbox.org/wiki/Changelog-5.2: VirtualBox 5.2.44 (released July 14 2020)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants