Sentinel commands support - #285
Closed
reva2 wants to merge 1 commit into
Closed
Conversation
Member
|
Sergey, Thanks a lot for this contribution! I am currently traveling but will |
Member
|
Hey there, Thanks for the pull request. I'll take a look at it as well :) Cheers, |
|
Has any further work been done on this? I'd really like to use this library with sentinel because predis is too slow. If these commands are implemented I will write an adapter for PSredis. |
|
+1 |
Member
|
I haven't specifically implemented the So for example:
Would work |
Contributor
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've add support for Sentinel's commands: SENTINEL masters, SENTINEL slaves , SENTINEL get-master-addr-by-name , SENTINEL reset .
I'm not C/C++ programmer. So, please check my code. Especially function 'redis_sock_read_multi_multibulk_reply_assoc' in file 'library.c'.
Documentation is also updated.