Skip to content

.deb related fixes#156

Merged
nicolasff merged 1 commit into
masterfrom
unknown repository
Apr 3, 2012
Merged

.deb related fixes#156
nicolasff merged 1 commit into
masterfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Apr 2, 2012

Copy link
Copy Markdown

Correct .deb filename (last git-tag name used as version number).
Unified php5/conf.d support (now usable with php5-fpm).

Unified php5/conf.d support.
@nicolasff

Copy link
Copy Markdown
Member

Hello Dmitry,

What is the aim of this pull request? It looks like mkdeb-apache2.sh, except without the compatibility code for Ubuntu vs Debian and none of the Apache files.

Thanks

@ghost

ghost commented Apr 2, 2012

Copy link
Copy Markdown
Author

First. Standards compliance:
«The Debian binary package file names conform to the following convention: -.deb»

Second.
AFAIK, best practice is using symlinks like «/etc/php5/conf.d -> /etc/php5/$SAPI/conf.d». ($SAPI - apache2, fpm or cli.)
So, /etc/php5/conf.d/redis.ini will be usable for all systems.
For example, see structure of php5-fpm package.

PS. Sorry, non native english speaker.

@georgekola

Copy link
Copy Markdown

the .deb built using this and installed works fine on ubuntu 12.04 with php5.3.10. The .deb built with mkdeb-apache2.sh does not work properly.

@nicolasff

Copy link
Copy Markdown
Member

@breathless thanks for your contribution and @georgekola thanks for your input.

nicolasff added a commit that referenced this pull request Apr 3, 2012
@nicolasff
nicolasff merged commit e1a65fd into phpredis:master Apr 3, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants