Repository navigation
Stop comments from starting multiline values - #615
Merged
Merged
Conversation
GrahamCampbell
force-pushed
the
tests/coverage-hardening
branch
from
August 24, 2026 17:28
21cd0f5 to
0945774
Compare
GrahamCampbell
force-pushed
the
fix/comment-multiline-priority
branch
from
August 24, 2026 17:28
28b36d6 to
3437eeb
Compare
GrahamCampbell
force-pushed
the
tests/coverage-hardening
branch
from
August 24, 2026 17:43
0945774 to
86ddd73
Compare
GrahamCampbell
force-pushed
the
fix/comment-multiline-priority
branch
from
August 24, 2026 17:43
3437eeb to
1411d10
Compare
GrahamCampbell
force-pushed
the
tests/coverage-hardening
branch
from
August 24, 2026 17:46
86ddd73 to
415b11c
Compare
GrahamCampbell
force-pushed
the
fix/comment-multiline-priority
branch
from
August 24, 2026 17:46
1411d10 to
445763b
Compare
GrahamCampbell
force-pushed
the
tests/coverage-hardening
branch
from
August 24, 2026 17:47
415b11c to
ea4b204
Compare
GrahamCampbell
force-pushed
the
fix/comment-multiline-priority
branch
from
August 24, 2026 17:47
445763b to
2e18096
Compare
GrahamCampbell
force-pushed
the
tests/coverage-hardening
branch
from
August 24, 2026 17:49
ea4b204 to
d135fe5
Compare
GrahamCampbell
force-pushed
the
fix/comment-multiline-priority
branch
from
August 24, 2026 17:49
2e18096 to
fe56ffc
Compare
GrahamCampbell
force-pushed
the
tests/coverage-hardening
branch
from
August 24, 2026 17:56
d135fe5 to
c34c7b1
Compare
GrahamCampbell
force-pushed
the
fix/comment-multiline-priority
branch
from
August 24, 2026 17:56
fe56ffc to
7a62b85
Compare
GrahamCampbell
force-pushed
the
tests/coverage-hardening
branch
from
August 24, 2026 17:57
c34c7b1 to
4bf5e0d
Compare
GrahamCampbell
force-pushed
the
fix/comment-multiline-priority
branch
from
August 24, 2026 17:57
7a62b85 to
a2d162e
Compare
GrahamCampbell
force-pushed
the
tests/coverage-hardening
branch
from
August 24, 2026 18:03
4bf5e0d to
7da2cde
Compare
GrahamCampbell
force-pushed
the
fix/comment-multiline-priority
branch
from
August 24, 2026 18:03
a2d162e to
9fbee84
Compare
GrahamCampbell
force-pushed
the
fix/comment-multiline-priority
branch
from
August 24, 2026 18:04
9fbee84 to
527062b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comment recognition happens only after multiline detection, and the multiline heuristic searches the whole physical line for a quote start, so a comment containing the characters =" opened a phantom multiline buffer: every following line was silently swallowed until a stray closing quote arrived or the buffer was discarded at end of file, making unrelated later assignments vanish without an error, including for realistic inputs like a URL value followed by a comment mentioning a quoted example. The multiline start is now ignored when a hash appears earlier in the line than the quote start, so comments can no longer open multiline values, while genuine multiline values, including ones whose opening line contains a hash inside the quotes, are unchanged. The only behaviour change on previously accepted input is that a stray quote line following such a comment now fails name validation loudly instead of being silently dropped with its neighbours. This is stacked on #608.