Repository navigation
Add regression tests for existing behaviour - #608
Merged
Merged
Conversation
GrahamCampbell
force-pushed
the
tests/coverage-hardening
branch
from
August 24, 2026 01:01
54680e7 to
a21b352
Compare
GrahamCampbell
force-pushed
the
fix/diagnostics
branch
from
August 24, 2026 01:01
b4dda79 to
13dcab6
Compare
GrahamCampbell
force-pushed
the
fix/diagnostics
branch
from
August 24, 2026 10:45
13dcab6 to
9c2ed87
Compare
GrahamCampbell
force-pushed
the
tests/coverage-hardening
branch
from
August 24, 2026 10:45
a21b352 to
60feb0b
Compare
GrahamCampbell
force-pushed
the
fix/diagnostics
branch
from
August 24, 2026 13:25
9c2ed87 to
618d1e6
Compare
GrahamCampbell
force-pushed
the
tests/coverage-hardening
branch
from
August 24, 2026 13:25
60feb0b to
21cd0f5
Compare
GrahamCampbell
force-pushed
the
fix/diagnostics
branch
from
August 24, 2026 17:28
618d1e6 to
bc97b0a
Compare
GrahamCampbell
force-pushed
the
tests/coverage-hardening
branch
from
August 24, 2026 17:28
21cd0f5 to
0945774
Compare
GrahamCampbell
force-pushed
the
fix/diagnostics
branch
from
August 24, 2026 17:43
bc97b0a to
218d077
Compare
GrahamCampbell
force-pushed
the
tests/coverage-hardening
branch
from
August 24, 2026 17:43
0945774 to
86ddd73
Compare
GrahamCampbell
force-pushed
the
fix/diagnostics
branch
from
August 24, 2026 17:46
218d077 to
203a836
Compare
GrahamCampbell
force-pushed
the
tests/coverage-hardening
branch
from
August 24, 2026 17:46
86ddd73 to
415b11c
Compare
GrahamCampbell
force-pushed
the
fix/diagnostics
branch
from
August 24, 2026 17:47
203a836 to
4252be6
Compare
GrahamCampbell
force-pushed
the
tests/coverage-hardening
branch
from
August 24, 2026 17:47
415b11c to
ea4b204
Compare
GrahamCampbell
force-pushed
the
fix/diagnostics
branch
from
August 24, 2026 17:49
4252be6 to
fe66af6
Compare
GrahamCampbell
force-pushed
the
tests/coverage-hardening
branch
from
August 24, 2026 17:49
ea4b204 to
d135fe5
Compare
GrahamCampbell
force-pushed
the
fix/diagnostics
branch
from
August 24, 2026 17:56
fe66af6 to
eee97bd
Compare
GrahamCampbell
force-pushed
the
tests/coverage-hardening
branch
from
August 24, 2026 17:56
d135fe5 to
c34c7b1
Compare
GrahamCampbell
force-pushed
the
fix/diagnostics
branch
from
August 24, 2026 17:57
eee97bd to
cf7a51b
Compare
GrahamCampbell
force-pushed
the
tests/coverage-hardening
branch
from
August 24, 2026 17:57
c34c7b1 to
4bf5e0d
Compare
GrahamCampbell
force-pushed
the
tests/coverage-hardening
branch
from
August 24, 2026 18:03
4bf5e0d to
7da2cde
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several behaviours that users rely on had no pinning test, so plausible regressions passed silently: interpolation immediately after multibyte text, the anchor that keeps an escaped nested reference literal next to a bare dollar sign, indented comments, and UTF-16 and UTF-32 files carrying a byte order mark with a matching file encoding. Two test helpers also ignored their expected-name argument. The immutable load test asserted only that getenv was unchanged, which the safe factories never write anyway, so it passed vacuously; it now asserts the load return value and each environment channel. This adds targeted coverage and fixes the helpers. This is stacked on #607.