Repository navigation
Added Validator for allowedRegexvalues - #370
Closed
treestonemedia wants to merge 3 commits into
Closed
treestonemedia wants to merge 3 commits into
treestonemedia wants to merge 3 commits into
Conversation
treestonemedia
commented
Sep 10, 2019
treestonemedia
commented
Contributor
- Added a function to check if an env variable's value matches a given regex.
- This was required for our project and I think is a nice addition to this amazing tool.
- Also added a test for allowedRegexValues().
- Also added a readme block.
Collaborator
|
Thanks for the PR. I wonder if we should require exactly one match, rather than at least 1? In your usage, which behaviour would be most useful? |
Contributor
Author
|
@GrahamCampbell good point - that was an oversight on my part - updated the PR |
Collaborator
|
Perfect. I've made some tweaks, and merged this into master (1bdf24f). |
Collaborator
|
This will be included in the v3.6.0 release. Thanks for the contribution! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.