Skip to content

[2.5] Fix variable values starting with hash are being converted into empty strings - #277

Merged
GrahamCampbell merged 2 commits into
phpdotenv:masterfrom
Korbeil:276-variable-values-starting-with-are-being-converted-into-empty-strings
Jul 29, 2018
Merged

GrahamCampbell merged 2 commits into
phpdotenv:masterfrom
Korbeil:276-variable-values-starting-with-are-being-converted-into-empty-strings

Conversation

@Korbeil

@Korbeil Korbeil commented Jul 2, 2018 •

Copy link
Copy Markdown
Contributor

Fixes #276

@murrant murrant left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@GrahamCampbell
GrahamCampbell merged commit 8abb4f9 into phpdotenv:master Jul 29, 2018
@GrahamCampbell GrahamCampbell changed the title 276 variable values starting with are being converted into empty strings [2.5] Fix variable values starting with hash are being converted into empty strings Jan 28, 2019
@GrahamCampbell

Copy link
Copy Markdown
Collaborator

NB The behaviour here has been changed in 3.x so that unquoted variables starting with a hash are now considered to be empty, as they will be parsed as comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants