Skip to content

[2.5] Added the list of environment variable declared inside the 'env' file - #199

Merged
GrahamCampbell merged 1 commit into
phpdotenv:masterfrom
jclebreton:get-env-variable-names
Jul 1, 2018
Merged

GrahamCampbell merged 1 commit into
phpdotenv:masterfrom
jclebreton:get-env-variable-names

Conversation

@jclebreton

Copy link
Copy Markdown
Contributor

No description provided.

@etiennecallies etiennecallies left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good idea! Approved :shipit: ! (some naming remarks though)

Comment thread src/Dotenv.php Outdated
*
* @return array
*/
public function getEnvironmentVariablesList()

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have called it getEnvironmentVariableNames

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment thread src/Dotenv.php Outdated
}

/**
* Get the list of environment variable declared inside the 'env' file.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: variables

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment thread src/Loader.php
* The list of environment variable declared inside the 'env' file.
*
* @var array
*/

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

variableNames ...

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@jclebreton

Copy link
Copy Markdown
Contributor Author

Hi @vlucas are you actively maintaining this library any more?

@GrahamCampbell
GrahamCampbell merged commit 6ae3e2e into phpdotenv:master Jul 1, 2018
@GrahamCampbell

Copy link
Copy Markdown
Collaborator

Thanks.

@GrahamCampbell GrahamCampbell changed the title Added the list of environment variable declared inside the 'env' file [2.5] Added the list of environment variable declared inside the 'env' file Jan 28, 2019
@GrahamCampbell

Copy link
Copy Markdown
Collaborator

@jclebreton Yes, this repo is still actively maintained. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants