Repository navigation
[2.6.0] Got DB connection error after update #336
Description
Hi, I'm using DB connection using .env file.
.env file looks like below :
DB_CONNECTION=mysql
DB_HOST=localhost
DB_PORT=3306
DB_DATABASE=homestead_h
DB_USERNAME=homestead
DB_PASSWORD=secret!@#
and I got Access denied for user ~~ error.
After revert phpdotenv's version 2.6.0 to 2.5.2, everything works fine.
Activity
zhouzyc commentedon Jan 29, 2019
I also have a connection error. After updating, the password has a # number.
zhouzyc commentedon Jan 29, 2019
robtesch commentedon Jan 29, 2019
Same issue with Laravel project. Tried every possible combination of quotes and no quotes. My password has a # in it if that's any help.
zhouzyc commentedon Jan 29, 2019
@robtesch
have a try
DB_PASSWORD=secret!@# ->DB_PASSWORD=”secret!@#“
erikscheepers commentedon Jan 29, 2019
Same error here, also a # in the password. Putting the password between quotes fixes the issue. My password looks like se#cret (no # at the end).
GrahamCampbell commentedon Jan 29, 2019
Thanks for the report. It looks like we're missing some tests.
GrahamCampbell commentedon Jan 29, 2019
The new version is parsing the hash as a comment.
GrahamCampbell commentedon Jan 29, 2019
I'm prepping a fix now.
GrahamCampbell commentedon Jan 29, 2019
Please let me know if #338 fixes your issue. :)
GrahamCampbell commentedon Jan 29, 2019
I've released v2.6.1 with the parser fixes.
robtesch commentedon Jan 29, 2019
@GrahamCampbell thanks very much, that fixed it. Out of interest, for future (v3+) how should we do it? Do we need to escape some chars?
GrahamCampbell commentedon Jan 29, 2019
The three differences are:
foo#barfoo#barfoo#barfoofoo # barfoofoofoo"iiiiviiiixiiiiviiii\n"iiiviiiixiiiiviiii\n"iiiiviiiixiiiiviiii\\n"iiiiviiiixiiiiviiii\niiiiviiiixiiiiviiii\niiiiviiiixiiiiviiii\n"foo\"bar"foo"barfoo"barfoo"bar" foo "foowith whitespace trimmedfoowith whitespace trimmedfoowith 2 spaces in front and one afterIn double quoted strings, double quotes and backslashes need escaping with a backslash, and in single quoted strings, single quote and backslashes need escaping with a backslash. In v2.5.2, forgetting an escape can lead to odd results due to the regex running out of stack, but this was fixed in 2.6 and 3.3, with 2.6 allowing you to continue after an unescaped backslash, but 3.3 not.
robtesch commentedon Jan 29, 2019
Good stuff, so just to confirm, even for v3.3+, if the input is:
"p455w0rd123#"it will come out as:
p455w0rd123#No need to escape anything since it's in double quotes and does not contain any double quotes or backslashes.
GrahamCampbell commentedon Jan 29, 2019
Yes, that's correct. :)