Skip to content

Rebuit composer.lock#916

Merged
jhdxr merged 1 commit into
phpbrew:masterfrom
morozov:composer-lock-rebuild
Oct 15, 2017
Merged

Rebuit composer.lock#916
jhdxr merged 1 commit into
phpbrew:masterfrom
morozov:composer-lock-rebuild

Conversation

@morozov
Copy link
Copy Markdown
Contributor

@morozov morozov commented Oct 13, 2017 •
edited
Loading

After the revert of composer.lock in #912, it's impossible to install PHPBrew with empty cache and vendor directory:

↪  composer install 
Loading composer repositories with package information
Installing dependencies (including require-dev) from lock file
Warning: The lock file is not up to date with the latest changes in composer.json. You may be getting outdated dependencies. Run update to update them.
Package operations: 27 installs, 0 updates, 0 removals
  - Installing symfony/finder (v2.8.5): Loading from cache
  - Installing symfony/polyfill-apcu (v1.1.1): Loading from cache
  - Installing symfony/class-loader (v2.8.5): Loading from cache
  - Installing pimple/pimple (v3.0.2): Loading from cache
  - Installing corneltek/universal (1.7.2): Downloading (failed)    Failed to download corneltek/universal from dist: The "https://api.github.com/repos/c9s/Universal/zipball/7815546cc524f6eac84d8f7620510e9277252d78" file could not be downloaded (HTTP/1.1 302 Found)
    Now trying to download from source
  - Installing corneltek/universal (1.7.2): Cloning 7815546cc5 from cache
    7815546cc524f6eac84d8f7620510e9277252d78 is gone (history was rewritten?)

According to packagist, the repository of the corneltek/universal package is now github.com/corneltek/Universal, not github.com/c9s/Universal where it fails to download from.

Additionally, corneltek/codegen:2.7.1 now points to c9s/CodeGen@265b089, not to c9s/CodeGen@b2a1835 as currently locked (seems re-released).

The lock file is rebuilt without updating dependencies.

@coveralls
Copy link
Copy Markdown

coveralls commented Oct 13, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 51.604% when pulling 53ab740 on morozov:composer-lock-rebuild into 522f600 on phpbrew:master.

@jhdxr
Copy link
Copy Markdown
Member

jhdxr commented Oct 15, 2017

Could you remove this line in this PR as well?

The CI is supposed to fail in this case. But due to the cache, in fact composer install did nothing. https://travis-ci.org/phpbrew/phpbrew/jobs/287167230#L386

@coveralls
Copy link
Copy Markdown

coveralls commented Oct 15, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 51.604% when pulling 3f3f1f4 on morozov:composer-lock-rebuild into 1245116 on phpbrew:master.

@jhdxr jhdxr merged commit 1afc170 into phpbrew:master Oct 15, 2017
@morozov morozov deleted the composer-lock-rebuild branch October 16, 2017 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@morozov @coveralls @jhdxr