Skip to content

Trying to fix failing build on Travis CI#912

Merged
jhdxr merged 1 commit into
phpbrew:masterfrom
morozov:remove-composer-lock
Oct 5, 2017
Merged

Trying to fix failing build on Travis CI#912
jhdxr merged 1 commit into
phpbrew:masterfrom
morozov:remove-composer-lock

Conversation

@morozov
Copy link
Copy Markdown
Contributor

@morozov morozov commented Sep 27, 2017 •
edited
Loading

Fixes #896.

Composer files are reverted to the state of 32cf0e5. The 4.0.x-dev release of corneltek/cliframework is incompatible with PHP 5.3 but doesn't declare that. It also seems to have some undeclared dependencies.

I'd like to propose a few measures to prevent similar issues in the future:

  1. Given we currently have dependencies on development versions of a few packages, we should avoid commits which update all/some dependencies w/o a clear reason why (e.g. d17c07d, 2b0a18a). Having them updated with explicitly specified package(s) and the reason of update (even it's an update for the sake of update) will help solving issues like this in the future. E.g. it will be clear what needs to be checked if the update is reverted.
  2. Everyone should use pull requests instead of making commits directly to master. It will help make sure the new code is built before getting into master and help having the changes better documented.

@coveralls
Copy link
Copy Markdown

coveralls commented Sep 27, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-1.4%) to 47.269% when pulling d213185 on morozov:remove-composer-lock into 2dfb863 on phpbrew:master.

@coveralls
Copy link
Copy Markdown

coveralls commented Sep 28, 2017 •
edited
Loading

Coverage Status

Coverage increased (+3.01%) to 51.64% when pulling 09fb767 on morozov:remove-composer-lock into 2dfb863 on phpbrew:master.

@morozov morozov changed the title [PoC] Trying to remove composer.lock to let Composer resolve dependencies based on the currently used PHP runtime Trying to fix failing build on Travis CI Sep 29, 2017
jhdxr
jhdxr approved these changes Sep 29, 2017
View reviewed changes
Copy link
Copy Markdown
Member

@jhdxr jhdxr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morozov morozov mentioned this pull request Sep 29, 2017
Closed
@morozov
Copy link
Copy Markdown
Contributor Author

morozov commented Oct 4, 2017

@jhdxr do you want to merge this so that subsequent pull requests could be verified on all PHP versions?

@jhdxr
Copy link
Copy Markdown
Member

jhdxr commented Oct 5, 2017

@morozov I'd like to check the difference between CLIFramework 3.x and 4.x first, in order to find the reason why @c9s upgraded it.

@jhdxr
Copy link
Copy Markdown
Member

jhdxr commented Oct 5, 2017

I think it's fine to revert CLIFramework back to 3.0.3. And I think before we implement this, it should not be upgraded to 4.x branch because it drops the support for 5.3 to 5.5: c9s/CLIFramework@aa08816

@jhdxr jhdxr merged commit 5379a5c into phpbrew:master Oct 5, 2017
@morozov morozov deleted the remove-composer-lock branch October 5, 2017 02:45
@jhdxr
Copy link
Copy Markdown
Member

jhdxr commented Oct 5, 2017

Thanks. the CI got green finally

@morozov morozov mentioned this pull request Oct 13, 2017
Merged
@morozov morozov mentioned this pull request Dec 19, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhdxr jhdxr jhdxr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@morozov @coveralls @jhdxr