Skip to content

Improve IMAP support on macOS#1202

Merged
morozov merged 4 commits into
phpbrew:masterfrom
morozov:imap
Oct 28, 2020
Merged

Improve IMAP support on macOS#1202
morozov merged 4 commits into
phpbrew:masterfrom
morozov:imap

Conversation

@morozov
Copy link
Copy Markdown
Contributor

@morozov morozov commented Oct 25, 2020

  1. Pass PKG_CONFIG_PATH via ./configure. Otherwise, the environment variable is set globally and isn't displayed in debug mode.
  2. Add ConfigureParameters::withOptionOrPkgConfigPath() since it seems to be a pattern depending on the PHP version.
  3. Collect all the needed dependencies for IMAP on macOS from Homebrew.
  4. Canonicalize version in the Build constructor. Otherwise, php-7.3.24RC1 is not less than 7.4.

Otherwise, the environment variable is set globally and isn't displayed in debug mode.
@morozov morozov merged commit 6e96d3c into phpbrew:master Oct 28, 2020
@morozov morozov deleted the imap branch October 28, 2020 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant