Skip to content

Get the ini info from the currently used PHP instead of the PHPBrew interpreter#1136

Merged
morozov merged 2 commits into
phpbrew:1.25from
morozov:issues/1134
Dec 29, 2019
Merged

Get the ini info from the currently used PHP instead of the PHPBrew interpreter#1136
morozov merged 2 commits into
phpbrew:1.25from
morozov:issues/1134

Conversation

@morozov
Copy link
Copy Markdown
Contributor

@morozov morozov commented Dec 28, 2019

Additionally, cleaned up handling exit codes in shell wrappers and fixed the exit code in phpbrew ext config.

Fixes #1134.

…nterpreter

Additionally, cleaned up handling exit codes in shell wrappers and fixed the exit code in `phpbrew ext config`.
@morozov morozov added Bash Fish Regression A bug that that was introduced as part of a feature or another bug fix System Interpreter labels Dec 28, 2019
@morozov morozov added this to the Release 1.25.2 milestone Dec 28, 2019
@morozov morozov changed the base branch from master to 1.25 December 28, 2019 22:28
@morozov
Copy link
Copy Markdown
Contributor Author

morozov commented Dec 29, 2019

I don't think we should be fixing the list-ini command. Its output is almost identical to the output of php --ini, it's going to be deprecated in 1.26.0.

By this logic, phpbrew infophp --info. It's currently fixed but I think we should deprecate it too.

@markwu
Copy link
Copy Markdown
Contributor

markwu commented Dec 29, 2019

It's really much simpler. Thanks.

@morozov morozov self-assigned this Dec 29, 2019
@morozov morozov merged commit 1102e2f into phpbrew:1.25 Dec 29, 2019
@morozov morozov deleted the issues/1134 branch December 29, 2019 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bash Fish Regression A bug that that was introduced as part of a feature or another bug fix System Interpreter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants