Fixed __phpbrew_normalize_build in Bash#1105
Merged
Merged
Conversation
As of #1101, `phpbrew use` does not accept the arguments that don't start with "php-". E.g.: ``` $ phpbrew list php-8.0.0-dev * php-7.4.1 php-7.3.13 php-7.1.33 php-5.6.40 php-5.3.29 $ phpbrew use 5.3.29 PHP version 5.3.29 is not installed. $ phpbrew use php-5.3.29 $ phpbrew use Currently using php-5.3.29 ``` The reason is that the moment when the vesion regular expression pattern was converted from a variable to a literal, it should have been unquoted.
morozov
added
Bug
Bash
Regression
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of #1101,
phpbrew usedoes not accept the arguments that don't start with "php-". E.g.:The reason is that the moment when the vesion regular expression pattern was converted from a variable to a literal, it should have been unquoted.