PHPUnit 7#1091
Merged
Merged
Conversation
1. `DiffPatchRule::backup()` was mistakenly removed by #1087 and has been restored. The missing `implements PatchRule` statement has been added for clarity. 2. The logic of `InstallCommandTest::testKnownCommand()` was moved under `::testInstallCommand()`, so the dependency is no longer relevant. 3. `PathCommandTest::testPathCommand()` depended on `::testUseLatestPHP()` which would set the PHPBREW_PHP environment variable but was removed since it was not in fact used. 4. The expectation of `--with-apxs2=` is replaced with `--with-apxs2` for the same reason as in #1070. 5. The `PHPUnit_Framework_TestCase` class alias is declared conditionally since it may or may not be needed depending on the actually used PHPUnit version.
morozov
added
Improvement
Patching PHP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DiffPatchRule::backup()was mistakenly removed by Code cleanup #1087 and has been restored. The missingimplements PatchRulestatement has been added for clarity.InstallCommandTest::testKnownCommand()was moved under::testInstallCommand()by Speed up slow tests on PHP 5 #1079, so the dependency is no longer relevant.PathCommandTest::testPathCommand()used to depend on::testUseLatestPHP()which would set thePHPBREW_PHPenvironment variable but was removed since it was not in fact used.--with-apxs2=is replaced with--with-apxs2for the same reason as in Cleaned up the test suite a bit #1070.PHPUnit_Framework_TestCaseclass alias is declared conditionally since it may or may not be needed depending on the actually used PHPUnit version.