Skip to content

Clean up the temporary directory used during a package extraction#1057

Merged
morozov merged 1 commit into
phpbrew:masterfrom
morozov:issues/1056
Nov 30, 2019
Merged

Clean up the temporary directory used during a package extraction#1057
morozov merged 1 commit into
phpbrew:masterfrom
morozov:issues/1056

Conversation

@morozov
Copy link
Copy Markdown
Contributor

@morozov morozov commented Nov 29, 2019

  1. Create a temporary directory only if needed.
  2. Remove it in the class destructor.

Fixes #1056.

@morozov morozov added the Bug label Nov 29, 2019
@morozov morozov self-assigned this Nov 29, 2019
@coveralls
Copy link
Copy Markdown

coveralls commented Nov 29, 2019

Coverage Status

Coverage decreased (-0.07%) to 40.222% when pulling cc7837f on morozov:issues/1056 into a3745f8 on phpbrew:master.

1. Create the temporary directory only if needed.
2. Remove it the class destructor.
@morozov morozov merged commit 040c806 into phpbrew:master Nov 30, 2019
@morozov morozov deleted the issues/1056 branch November 30, 2019 01:15
@morozov morozov added this to the Release 1.25.0 milestone Nov 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PHPBrew doesn't remove the temporary directory created during installation

2 participants