Conversation
dantleech
force-pushed
the
poc-opcode-counter
branch
from
4f8964b to
aa1ed36
Compare
dantleech
force-pushed
the
poc-opcode-counter
branch
3 times, most recently
from
519a643 to
e515a93
Compare
dantleech
force-pushed
the
poc-opcode-counter
branch
4 times, most recently
from
8502c67 to
8e34ac3
Compare
dantleech
commented
Jun 22, 2024
| namespace PhpBench\Expression\Exception; | ||
|
|
||
| class KeyDoesNotExist extends EvaluationError | ||
| class VariableNotFound extends EvaluationError |
Member
Author
There was a problem hiding this comment.
previously unused class, technically a B/C break but 🤷 -- although to be safe may as well deprecate it and create a new class.
- Show opcode count in aggregate report - Throw specific exception when variable not found - Show stdev on aggregate report - Add option to expression-generator to hide columsn with missing vars (e.g. opcode count) - Move stuff around the executor hierarchy to enable more reuse 🙃 - @deprecate the PARAM_SAFE_PARAMTER template-executor constant to force removal in 2.0 - Allow opcode executor to be pre or post optimisation - Option to dump opcache output to path - Test opcode dump for file with > 1000 lines Test > 1000 lines
dantleech
force-pushed
the
poc-opcode-counter
branch
from
8e34ac3 to
f87176c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--executor=opcode@deprecatethe PARAM_SAFE_PARAMTER template-executor constant to force removal in 2.0TODO: