fix(BinaryExpressionResolver): null coalesce on undefined variable#3031
Merged
dantleech merged 1 commit intophpactor:masterfrom Mar 21, 2026
Merged
fix(BinaryExpressionResolver): null coalesce on undefined variable#3031dantleech merged 1 commit intophpactor:masterfrom
dantleech merged 1 commit intophpactor:masterfrom
Conversation
Contributor
Author
while on master: |
przepompownia
changed the title
Collaborator
|
in the screen shot it complains that |
Contributor
|
This makes sense, php (when prod mode is on) just prefills undefined variables with null and the expression will evaluate to an empty array. I don't think that getting rid of the diagnostic is a good idea though. |
Contributor
Author
|
In this case, the code is correct. The complaint is more about potentially bad practice – perhaps it should be shown as a warning (to fix somewhere else). |
Collaborator
|
happy for the diagnostic to be changed to a warning |
dantleech
force-pushed
the
undef-null-coal
branch
2 times, most recently
from
8dd8348 to
b21d9d3
Compare
przepompownia
force-pushed
the
undef-null-coal
branch
from
b21d9d3 to
010e98b
Compare
Contributor
Author
|
@dantleech I guess you test benchmark here and we probably did the rebase at almost the same time :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #3030
In practice:
$bazfrom the test case