Converting string to heredoc and back#2825
Merged
dantleech merged 2 commits intophpactor:masterfrom Jan 27, 2025
Merged
Conversation
dantleech
reviewed
Jan 27, 2025
lib/CodeTransform/Adapter/WorseReflection/Refactor/WorseHereDoc.php
Outdated
Show resolved
Hide resolved
dantleech
reviewed
Jan 27, 2025
lib/CodeTransform/Adapter/WorseReflection/Refactor/WorseHereDoc.php
Outdated
Show resolved
Hide resolved
Collaborator
|
look fine, just a minor comments. |
Collaborator
|
thanks |
Contributor
|
This just happens to coincide with my need to use it in many cases in some project :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code action can refactor strings to here docs and the other way around.
The String parsing in the tolerant parser is really weird though, whitespaces are parts of the tokens.