Skip to content

Serialize ChromeOptions object under ChromeOptions::CAPABILITY_W3C capability index#850

Closed
gvlasov wants to merge 1 commit into
php-webdriver:mainfrom
gvlasov:chrome-options-w3c-serialization-bug
Closed

Serialize ChromeOptions object under ChromeOptions::CAPABILITY_W3C capability index#850
gvlasov wants to merge 1 commit into
php-webdriver:mainfrom
gvlasov:chrome-options-w3c-serialization-bug

Conversation

@gvlasov
Copy link
Copy Markdown

@gvlasov gvlasov commented Dec 27, 2020

For bug report #849

@gvlasov
Copy link
Copy Markdown
Author

gvlasov commented Dec 27, 2020

These changes should have been present in #673

@andrewnicols
Copy link
Copy Markdown
Member

I don't think that this is the right approach. The current approach there is a stop-gap solution which has side-effects as noted in the TODO.

See my alternative proposal in #852

@andrewnicols
Copy link
Copy Markdown
Member

I think that we can close this issue now that #852 has landed. Landing this change is not mutually exclusive, but will lead to further b/c breakages in future when we do release 2.0 and stop converting modifying the content of $this->capabilities.

Do you agree @OndraM?

@OndraM
Copy link
Copy Markdown
Collaborator

OndraM commented Jan 12, 2021

Sure, closing this, as it has been covered by #852. Thanks @gvlasov for the suggestion, though!

@OndraM OndraM closed this Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants