Enable W3C protocol for Chrome 🎉#674
Merged
Merged
Conversation
Until now, W3C was forcily disabled for Chromedriver using Capabilities on startup. As we now experimentaly support W3C protocol, this is no longer needed. If W3C is detected during initial handshake, the browser will be started using W3C dialect (otherwise it will use legacy OSS JsonWire protocol).
… the old protocol
8962f08 to
041658b
Compare
This was referenced Nov 11, 2019
This was referenced Dec 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
W3C protocol was forced to be disabled when using Chrome (#640).
But now we can remove this and let the handshake added in #560 to determine the proper protocol to use. So starting to next release of php-webdriver (1.8.0), W3C protocol will be used be default when used with Chromedriver 75+ (and also with Firefox+Geckodriver).
In case of troubles this could be still disabled using capabilities (as we do in on travis build):