Skip to content

updating to latest chromeWebdriver options structure#652

Closed
abidulrmdn wants to merge 1 commit into
php-webdriver:communityfrom
abidulrmdn:fix-chromeoptions-fordeps
Closed

updating to latest chromeWebdriver options structure#652
abidulrmdn wants to merge 1 commit into
php-webdriver:communityfrom
abidulrmdn:fix-chromeoptions-fordeps

Conversation

@abidulrmdn
Copy link
Copy Markdown

Chrome WebDriver has changed the chrome options lately which leaves this repo a broken dependency to all other modules using this as a base.
CAPABILITY should 'goog:chromeOptions' instead of 'chromeOptions'

Chrome WebDriver has changed the chrome options lately which leaves this repo a broken dependency to all other modules using this as a base.
`CAPABILITY` should 'goog:chromeOptions' instead of 'chromeOptions'
@facebook-github-bot
Copy link
Copy Markdown

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@abidulrmdn
Copy link
Copy Markdown
Author

Related issue in here
#653

@facebook-github-bot
Copy link
Copy Markdown

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@attilix
Copy link
Copy Markdown

attilix commented Sep 25, 2019

Great! We have a fix, when will this be merged?

@abidulrmdn
Copy link
Copy Markdown
Author

@OndraM How do we get this merged?

@OndraM
Copy link
Copy Markdown
Collaborator

OndraM commented Nov 10, 2019

Hi @abdrmdn, thanks for the contribution!

However Chromedriver still supports chromeOptions. And simply changing it to goog:chromeOptions will break support for Chromedrivers older than version 2.31, where the support was added ... There must be some kind of workaround (which I'm working on right now] to support both of the keys, depending on protocol.

@OndraM OndraM closed this Nov 10, 2019
@abidulrmdn
Copy link
Copy Markdown
Author

@OndraM Great, thanks man!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants