Skip to content

Update platform capability to match the w3c spec#461

Closed
paulbriton wants to merge 2 commits into
php-webdriver:communityfrom
paulbriton:community
Closed

Update platform capability to match the w3c spec#461
paulbriton wants to merge 2 commits into
php-webdriver:communityfrom
paulbriton:community

Conversation

@paulbriton
Copy link
Copy Markdown

According to the spec, the capability platform has changed :

"platformName"
Lowercase name of the current platform as a string.

@paulbriton
Copy link
Copy Markdown
Author

By the way, I think we could remove Windows XP since some drivers doesn't support it, as well as Microsoft..

@OndraM
Copy link
Copy Markdown
Collaborator

OndraM commented Feb 17, 2018

Hi @paulbriton and thanks for the contribution!

FYI this pull request is now intentionally on hold. We cannot simply change features to support W3C protocol, as it could break current OSS JsonWire protocol (and won't be supported there either).

So this will be solved as part of #469 , where this will be part of W3C adapter (and will be untouched for JsonWire protocol).

So I'm keeping this PR open for now, will take care of it later.

@gohelkiran
Copy link
Copy Markdown

any updates on this? there are many errors with UnknownCommandException with latest versions of Geckodriver, Firefox and Selenium web driver.
Any plan in near future or solutions to solve this errors
#580

@OndraM
Copy link
Copy Markdown
Collaborator

OndraM commented Sep 20, 2018

@dunglas , do you think this should be meged into #560 or done separately? Or this should be part of the Adapter layer?

@dunglas
Copy link
Copy Markdown
Contributor

dunglas commented Sep 20, 2018

@OndraM I've not looked at capabilities yet, I've no idea. If this change is compatible with Chrome, we may merge it separately?

@OndraM OndraM added this to the 2.0 milestone Nov 12, 2019
@OndraM
Copy link
Copy Markdown
Collaborator

OndraM commented Nov 23, 2019

This was superseded by #678 - capabilities should be W3C compatible in upcoming release 1.8.0 🎉 .

Thanks @paulbriton and sorry for letting you wait :)

@OndraM OndraM closed this Nov 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants