remove unused parseComparison method and simplify binary operator parsing logic

rokde · rokde · commit 69b1e82e2c39 · 2025-11-11T20:17:49.000+01:00
diff --git a/src/Core/Parser.php b/src/Core/Parser.php
@@ -219,27 +219,10 @@ private function parseAssignment(): Node
      * @throws \PhpScript\Exceptions\ParseException
      */
     private function parseComparison(): Node
-    {
-        $node = $this->parseConcat();
-
-        while ($this->match(TokenType::T_COMPARE_EQUALS, TokenType::T_COMPARE_UNEQUALS, TokenType::T_GREATER_THAN, TokenType::T_LESS_THAN)) {
-            $token = $this->previous();
-            $operator = $this->previous()->type;
-            $right = $this->parseConcat();
-            $node = new BinaryOperation($node, $operator, $right, $token);
-        }
-
-        return $node;
-    }
-
-    /**
-     * @throws \PhpScript\Exceptions\ParseException
-     */
-    private function parseConcat(): Node
     {
         $node = $this->parseAdditive();
 
-        while ($this->match(TokenType::T_CONCAT)) {
+        while ($this->match(TokenType::T_COMPARE_EQUALS, TokenType::T_COMPARE_UNEQUALS, TokenType::T_GREATER_THAN, TokenType::T_LESS_THAN)) {
             $token = $this->previous();
             $operator = $this->previous()->type;
             $right = $this->parseAdditive();
diff --git a/tests/Unit/Core/ParserTest.php b/tests/Unit/Core/ParserTest.php
@@ -81,7 +81,7 @@ function parse(string $code): Node
 });
 
 it('parses various binary operators', function (): void {
-    $operators = ['+', '-', '*', '/', '~', '==', '!=', '>', '<'];
+    $operators = ['+', '-', '*', '/', '==', '!=', '>', '<'];
     foreach ($operators as $op) {
         $program = parse("1 {$op} 2;");
         $statement = $program->statements[0];
