Declare compatibility with PHP 8.x#19
Merged
Merged
Conversation
Contributor
Author
|
Maybe it would even be possible to make the version unconstrained, so composer installs for new PHP versions are not blocked by this package. |
Jean85
approved these changes
Oct 13, 2020
Member
Jean85
left a comment
Jean85
left a comment
There was a problem hiding this comment.
LGTM 👍
Uncostrained is dangerous IMHO for such long-lived versions like PHP-FIG's packages, since we could risk getting those installed even if not compatible at all in the future. ^8.0 is enough.
|
Hi, a review and merge would be greatly appreciated because this package is currently breaking PHP8 builds. Thanks! |
weierophinney
approved these changes
Nov 2, 2020
|
Hi! A tagged release would be greatly appreciated so other packages don't need to depend on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't see why this package should not be declared as compatible with PHP 8.