Fix DBGP emulator handling only one command - #62
Merged
carlos-granados merged 1 commit intoMay 5, 2026
Merged
Conversation
carlos-granados
force-pushed
the
fix/dbgp-emulator
branch
2 times, most recently
from
April 22, 2026 16:19
d7843ff to
2987506
Compare
pronskiy
self-requested a review
May 4, 2026 00:22
pronskiy
approved these changes
May 4, 2026
carlos-granados
force-pushed
the
fix/dbgp-emulator
branch
from
May 4, 2026 11:27
2987506 to
74c3d17
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When I created this emulator, I only tested it with a "commands" file which only contained one command but when I actually tried to use it with more commands I found out that only the first command was passed. Turns out that the
doRead()function of the base class always returns null, independently of whether it correctly read some data or not, so the check for the return value always failed 🤦 Turns out that this check is not really needed and checking if the connection has been closed is enoughThe explanation is much longer than the fix! 😆