Skip to content

feat: benchmark when the debugger is connected - #54

Merged
carlos-granados merged 1 commit into
php-debugger:mainfrom
carlos-granados:feat/benchmark-debugger-connected
Apr 22, 2026
Merged

carlos-granados merged 1 commit into
php-debugger:mainfrom
carlos-granados:feat/benchmark-debugger-connected

Conversation

@carlos-granados

@carlos-granados carlos-granados commented Apr 15, 2026 •

Copy link
Copy Markdown
Collaborator

Adds a new case for our benchmark where we measure the performance when the debugger connects to a dbgp client which just asks it to run the code. This will allow us to measure future performance gains in this mode

See benchmark run which shows the results for this mode:

https://github.com/php-debugger/php-debugger/actions/runs/24467571172

@carlos-granados carlos-granados added the performance-check Add this label to run the performance CI workflow label Apr 15, 2026
@carlos-granados
carlos-granados force-pushed the feat/benchmark-debugger-connected branch from 0095216 to 2d8795d Compare April 15, 2026 15:57
@carlos-granados carlos-granados added performance-check Add this label to run the performance CI workflow and removed performance-check Add this label to run the performance CI workflow labels Apr 15, 2026
@carlos-granados
carlos-granados force-pushed the feat/benchmark-debugger-connected branch from 2d8795d to f297627 Compare April 15, 2026 16:05
@carlos-granados carlos-granados added performance-check Add this label to run the performance CI workflow and removed performance-check Add this label to run the performance CI workflow labels Apr 15, 2026
@carlos-granados
carlos-granados force-pushed the feat/benchmark-debugger-connected branch from f297627 to f83c7b6 Compare April 15, 2026 16:16
@carlos-granados carlos-granados added performance-check Add this label to run the performance CI workflow and removed performance-check Add this label to run the performance CI workflow labels Apr 15, 2026
@carlos-granados
carlos-granados force-pushed the feat/benchmark-debugger-connected branch from f83c7b6 to 20fab2f Compare April 15, 2026 16:20
@carlos-granados carlos-granados added performance-check Add this label to run the performance CI workflow and removed performance-check Add this label to run the performance CI workflow labels Apr 15, 2026
@carlos-granados
carlos-granados force-pushed the feat/benchmark-debugger-connected branch from 20fab2f to 681131c Compare April 15, 2026 16:27
@carlos-granados carlos-granados added performance-check Add this label to run the performance CI workflow and removed performance-check Add this label to run the performance CI workflow labels Apr 15, 2026
@carlos-granados
carlos-granados force-pushed the feat/benchmark-debugger-connected branch from 681131c to 2917b71 Compare April 15, 2026 16:34
@carlos-granados carlos-granados added performance-check Add this label to run the performance CI workflow and removed performance-check Add this label to run the performance CI workflow labels Apr 15, 2026
@carlos-granados
carlos-granados force-pushed the feat/benchmark-debugger-connected branch from 2917b71 to 1242e9e Compare April 15, 2026 17:03
@carlos-granados carlos-granados added performance-check Add this label to run the performance CI workflow and removed performance-check Add this label to run the performance CI workflow labels Apr 15, 2026
@carlos-granados
carlos-granados marked this pull request as ready for review April 15, 2026 17:30
@carlos-granados
carlos-granados force-pushed the feat/benchmark-debugger-connected branch 2 times, most recently from f36e415 to 416b5b0 Compare April 19, 2026 19:37

@pronskiy pronskiy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@carlos-granados
carlos-granados force-pushed the feat/benchmark-debugger-connected branch from 416b5b0 to 3299a7d Compare April 22, 2026 16:15
@carlos-granados
carlos-granados merged commit dfa3223 into php-debugger:main Apr 22, 2026
14 checks passed
@carlos-granados
carlos-granados deleted the feat/benchmark-debugger-connected branch April 22, 2026 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

performance-check Add this label to run the performance CI workflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants